Hi,
On 26-02-15 10:56, Jens Thiele wrote:
commit a5586a2f4aee9b5a5c571b47bbd87790a1ea0f83 (HEAD,
refs/remotes/karme/master, refs/heads/prisirah)
Author: Jens Thiele <[email protected]>
Date: Thu Feb 26 10:51:49 2015 +0100
TP_SENSITIVE_ADJUST(0) works better for me (using touch pen)
using TP_SENSITIVE_ADJUST(15) i get a lot of noise painting with low
pressure. I prefer not to get any events in that case.
Modified drivers/input/touchscreen/sun4i-ts.c
This seems to be against the upstream driver, correct? If so then linux-sunxi
is not the
correct email address to send patches to:
[hans@shalem linux]$ scripts/get_maintainer.pl -f
drivers/input/touchscreen/sun4i-ts.c
Dmitry Torokhov <[email protected]> (maintainer:INPUT
(KEYBOARD,...,commit_signer:4/6=67%)
Maxime Ripard <[email protected]> (maintainer:ARM/Allwinner
A1X...,commit_signer:2/6=33%)
Hans de Goede <[email protected]>
(commit_signer:3/6=50%,authored:3/6=50%,added_lines:374/457=82%,removed_lines:31/49=63%)
[email protected] (open list:INPUT (KEYBOARD,...)
[email protected] (moderated list:ARM/Allwinner A1X...)
[email protected] (open list)
Also please add a "Signed-off-by: Jens Thiele <[email protected]>" line when
sending patches for the
upstream kernel.
Now as for the patch itself:
diff --git a/drivers/input/touchscreen/sun4i-ts.c
b/drivers/input/touchscreen/sun4i-ts.c
index 28a0674..e692f8e 100644
--- a/drivers/input/touchscreen/sun4i-ts.c
+++ b/drivers/input/touchscreen/sun4i-ts.c
@@ -267,7 +267,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
* sensitive_adjust = 15 : max, which is not all that sensitive,
* tp_mode = 0 : only x and y coordinates, as we don't use dual touch
*/
- writel(TP_SENSITIVE_ADJUST(15) | TP_MODE_SELECT(0),
+ writel(TP_SENSITIVE_ADJUST(0) | TP_MODE_SELECT(0),
ts->base + TP_CTRL2);
/* Enable median filter, type 1 : 5/3 */
Hmm, what about using 7 by default as middle ground ? And can you please make
this configurable
through devicetree, and when you do so also update
Documentation/devicetree/bindings/input/touchscreen/sun4i.txt
Thanks & Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
