Hans de Goede <[email protected]> writes:

> Hi,

Hi,

Sorry, I should really have written at least some text and not only
"fyi" in the subject line.

It really was only meant as "for your interest" and the patch isn't
intended to be applied upstream / it is just what i use for myself and
to maybe help others that might prefer such a settting with the touch
screen they have at hand.

Especially, I don't think it is the better setting in general.

[...]

> Now as for the patch itself:
>
>> diff --git a/drivers/input/touchscreen/sun4i-ts.c 
>> b/drivers/input/touchscreen/sun4i-ts.c
>> index 28a0674..e692f8e 100644
>> --- a/drivers/input/touchscreen/sun4i-ts.c
>> +++ b/drivers/input/touchscreen/sun4i-ts.c
>> @@ -267,7 +267,7 @@ static int sun4i_ts_probe(struct platform_device *pdev)
>>       * sensitive_adjust = 15 : max, which is not all that sensitive,
>>       * tp_mode = 0 : only x and y coordinates, as we don't use dual touch
>>       */
>> -    writel(TP_SENSITIVE_ADJUST(15) | TP_MODE_SELECT(0),
>> +    writel(TP_SENSITIVE_ADJUST(0) | TP_MODE_SELECT(0),
>>             ts->base + TP_CTRL2);
>>
>>      /* Enable median filter, type 1 : 5/3 */
>>
>
>
> Hmm, what about using 7 by default as middle ground ? 

i don't think this will really help anyone

> And can you please make this configurable
> through devicetree, and when you do so also update 
> Documentation/devicetree/bindings/input/touchscreen/sun4i.txt
>
> Thanks & Regards,

the problem i see:
at least the touch screens i have got all differ in quality/sensitivity
=> imho a static assignment via devicetree won't really cut it (but yes
it would make adjustment easier).

I thought about a module argument or even better adjustment at runtime,
but I don't even know wether there is something like a standard user
space API for that (afair the synaptics touchpad always had a special
handling for that?)

greetings,
jens

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to