On Fri, 27 Nov 2015 15:35:16 +0100 Bernhard Nortmann <[email protected]> wrote:
> This series of patches picks up on the discussion at > https://groups.google.com/forum/#!topic/linux-sunxi/lz0oQBwjex0 > It's based on first patches submitted there, but has been extensively > reworked to provide a flexible "progress framework" for USB uploads via > the sunxi-fel utility. > > The large number of patches is partly due to the fact that I've tried to > introduce several features in discrete steps, with a logical separation > between them. Patch 4/9 already provides a simple, "proof of concept" > progress bar display based on what was proposed initially. > > Other patches extend on that, while demonstrating that the framework > allows progress routines and sunxi-fel 'core' to be updated mostly > independent of each other. > > Regards, B. Nortmann > > > Changes in v5: > - Rebased patches against current linux-sunxi/sunxi-tools (c32eeb8). > - Simplified progress_update() to only pass "bytes done" (for each chunk), > and have progress_start() pass the expected total size in advance. > - Dropped the idea of selecting transfer chunk size based on soc_id > (previous patch 5/9 "refine progress updates by adjusting transfer > chunk size"). Use a fixed value of 128 KiB per request instead. > - The progress bar was modified to output total size and transfer speed > at completion, which makes the previous pr_info() from within "write" > mostly obsolete. As suggested, it has been removed. > - Remove the planned "-g" and "-gg" options again, and instead introduce > more explicit (and 'stateless') commands to request various styles of > progress output. The "-p" option remains as a 'quick and dirty' way to > get progress bars and transfer statistics on standard "write" commands, > without having to do a lot of typing. (The more verbose options are > mainly intended for scripting.) > > Changes in v4: > - An attempt to support "per SoC" chunk size selection, now OBSOLETE. > > Bernhard Nortmann (9): > sunxi-tools: Introduce progress framework > sunxi-tools: refactor aw_fel_write() > sunxi-tools: extend usb_bulk_send() for progress updates > sunxi-tools: implement simple progress bar for larger transfers > sunxi-tools: extend progress display with transfer rate and ETA > sunxi-tools: Add file_size() and factor out a reusable file_upload() > sunxi-tools: implement "write-with-progress" and "multiwrite" > sunxi-tools: support FEL progress gauge via dialog utility > sunxi-tools: support updating the caption for "dialog --gauge" > > Makefile | 2 +- > fel.c | 225 > ++++++++++++++++++++++++++++++++++++++++++++++++------------- > progress.c | 165 +++++++++++++++++++++++++++++++++++++++++++++ > progress.h | 42 ++++++++++++ > 4 files changed, 388 insertions(+), 46 deletions(-) > create mode 100644 progress.c > create mode 100644 progress.h Hello, I think that patches 1-5 can be pushed to github, even though I'm not completely happy about certain aspects of them. The patches 6-9 may need some additional fixes. Oh, by the way. The "sunxi-tools:" prefix in the commit summaries is redundant in the github repository (because we already know that the whole thing is "sunxi-tools"). A better prefix would be "fel:". This minor commit summary tweak can be done when pushing patches. Thanks for working on this. Looks like we are now very close to having a perfect progress bar implementation in sunxi-fel. -- Best regards, Siarhei Siamashka -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
