Hi, On Sun, Nov 6, 2016 at 10:23 PM, Hans de Goede <[email protected]> wrote: > Hi, > > On 06-11-16 11:54, Icenowy Zheng wrote: >> >> >> >> 06.11.2016, 18:13, "Hans de Goede" <[email protected]>: >>> >>> Hi, >>> >>> On 06-11-16 04:35, Chen-Yu Tsai wrote: >>>> >>>> Hi everyone, >>>> >>>> I spent a bit of time adding DRM support for the A23 yesterday. >>>> Icenowy successfully got DRM working for the A33 Q8 tablets. >>>> >>>> It occurred to me today that we have 2 types of panels for the >>>> A33 Q8 tablets, one is 800x480 and the other is 1024x600. However >>>> we are currently sharing the same dts file for both, and only >>>> U-boot knows about the different resolutions. >>>> >>>> I see 2 ways to fix this. One would be to provide a separate >>>> dts file for the 1024x600 variant. The other would be to get >>>> U-boot to patch the dts file. >>>> >>>> Either way would require users upgrading U-boot, or at least >>>> their boot scripts in the first case, though. >>>> >>>> Any ideas? >>> >>> >>> Since we already have 2 u-boot configs for this having 2 dts files >>> seems like the best solution to me. >> >> >> Maybe for compatibility we need 3 dts files... >> >> 1. Q8 dts : everything except display (For users migrated from the old >> single-dt time) >> 2. Q8 800x480 dts : #include <Q8 dts>, /panel/compatible = >> "urt,umsh-8596md-t" >> /* This compatible is what Chen-Yu used in sun5i-q8, and I used it also >> on my A33 Q8 */ >> 3. Q8 1024x600 dts : #include <Q8 dts>, /panel/compatible = foo > > > Ah yes, I was wondering how to deal with older u-boot and > users then potentially getting the wrong panel setting. > > This is much better.
As part of my work to get DRM working on the A23, my plan was to add the tcon links and panel sans compatible to sun8i-reference-tablet.dtsi, and enable the display pipeline in sun8i-q8-common.dtsi. What I have already: https://github.com/wens/linux/commits/a23-drm I still need to see if the panel lights up and works tomorrow. There's also the vblank timeout issue both Icenowy and myself have run into. This was before I thought of the issue with the A33 Q8 tablets though. But we could just move the enable bits to the individual tablet dts files that we're going to create as Icenowy suggested. Regards ChenYu -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
