Hi Hans, On Tue, Nov 08, 2016 at 08:24:11PM +0100, Hans de Goede wrote: > > > > then we don't really need two different device > > > > trees in the first place, do we? > > > > > > It all depends on how closely we want to couple u-boot and the kernel. > > > > > > Either we need to have u-boot patch in the right panel compatible, but > > > only on q8_a33_tablet configs, or we stick with the one defconfig > > > 1 dts pattern used everywhere. > > > > > > Basically the problem is that currently both: > > > > > > configs/q8_a33_tablet_1024x600_defconfig > > > configs/q8_a33_tablet_800x480_defconfig > > > > > > Refer to the same dts, fixing that is really easy and > > > consistent with what we do in the other 100 sunxi defconfig-s > > > u-boot now has. Where as hot patching the panel compatible > > > requires q8_a33_tablet specific code in u-boot which I > > > would rather avoid. > > > > I definitely get that, but weren't you supposed to deal with that in > > your q8-manager? > > The q8-manager is for dealing with detectable hw differences, the > reason why we have 2 defconfigs for the a33 tablet is because the > panel cannot be detected. Making the q8-manager do the panel > compatible patches would require somehow telling it which defconfig > we booted with, at which point we might just as well directly > set the panel compatible.
I thought you could guess the screen size through secondary informations like the touchscreen and so on. My bad :) Then yes, if we can't, we don't really have the choice but to have two DT. > > And you'll have to have q8 specific code somewhere anyway, so if it's > > not in U-Boot, it's going to be somewhere else, it's just moving the > > problem to someone else indefinitely. > > Right, we do need q8 specific code somewhere, but so far I still hope > to put it in the kernel (which is probably naive of me). > > But you have a point, we could have a bit of q8 specific code in u-boot > to do the panel compatible patching (since we will likely need more > q8 specific code anyways). Still it would be easier to just have > 2 different dts files, what are your objections against that ? I don't think I have any if you can't detect it automatically. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
