Colin Cross wrote at Wednesday, February 23, 2011 2:08 PM: > > On Wed, Feb 23, 2011 at 10:58 AM, Stephen Warren <[email protected]> wrote: > > * Set up platform data required by I2C, and ASoC machine & codec drivers. > > * Enable required GPIO pins as GPIOs. > > * Initialize audio-related clocks. > > * Correctly configure pinmux for audio-related GPIOs. > > > > Signed-off-by: Stephen Warren <[email protected]> > > diff --git a/arch/arm/mach-tegra/board-harmony.h > > b/arch/arm/mach-tegra/board-harmony.h > > ... > > +#define GPIO_WM8903(_x_) (TEGRA_NR_GPIOS + (_x_)) > Can you name this HARMONY_GPIO_WM8903?
Sure. But then, wouldn't it make sense to also rename all the TEGRA_GPIO_* below too? > > + > > #define TEGRA_GPIO_SD2_CD TEGRA_GPIO_PI5 > > #define TEGRA_GPIO_SD2_WP TEGRA_GPIO_PH1 > > #define TEGRA_GPIO_SD2_POWER TEGRA_GPIO_PT3 > > #define TEGRA_GPIO_SD4_CD TEGRA_GPIO_PH2 > > #define TEGRA_GPIO_SD4_WP TEGRA_GPIO_PH3 > > #define TEGRA_GPIO_SD4_POWER TEGRA_GPIO_PI6 > > +#define TEGRA_GPIO_CDC_IRQ TEGRA_GPIO_PX3 > > +#define TEGRA_GPIO_SPKR_EN GPIO_WM8903(2) > > +#define TEGRA_GPIO_HP_DET TEGRA_GPIO_PW2 > > +#define TEGRA_GPIO_INT_MIC_EN TEGRA_GPIO_PX0 > > +#define TEGRA_GPIO_EXT_MIC_EN TEGRA_GPIO_PX1 -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
