On 05/30/2014 05:20 AM, Hiroshi Doyu wrote:
> Add sdhci iommus bindings.

This isn't adding bindings, it's adding DT properties. A binding is the
documentation of the schema, not the actual data in the DT.

> diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
> index 5b339ca8a1ab..011831ffd390 100644
> --- a/arch/arm/boot/dts/tegra124.dtsi
> +++ b/arch/arm/boot/dts/tegra124.dtsi
> @@ -472,6 +472,7 @@
>               resets = <&tegra_car 14>;
>               reset-names = "sdhci";
>               status = "disabled";
> +             iommus=<&smmu TEGRA_SWGROUP_CELLS(SDMMC1A)>;

Is the "iommus" property documented anywhere? I suspect not, since
there's an active ongoing discussion about how IOMMU bindings should be
structured. I suspect this series needs to wait until that discussion
completes, and the "iommus" property is documented somewhere.

There should be spaces around the = i.e. iommus = <...>;
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to