po 21. 10. 2024 v 17:12 odesÃlatel furkanonder <[email protected]> napsal: > > The enhancements made to timerlat_load.py are aimed at improving the clarity > of argument parsing. > > Summary of Changes: > - The cpu argument is now specified as an integer type in the argument > parser to enforce input validation, and the construction of affinity_mask > has been simplified to directly use the integer value of args.cpu. > - The prio argument is similarly updated to be of integer type for > consistency and validation, eliminating the need for the conversion of > args.prio to an integer, as this is now handled by the argument parser. > > Signed-off-by: Furkan Onder <[email protected]> > --- > tools/tracing/rtla/sample/timerlat_load.py | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/tools/tracing/rtla/sample/timerlat_load.py > b/tools/tracing/rtla/sample/timerlat_load.py > index 785e9a83539a..d7341ed5127a 100644 > --- a/tools/tracing/rtla/sample/timerlat_load.py > +++ b/tools/tracing/rtla/sample/timerlat_load.py > @@ -25,13 +25,12 @@ import sys > import os > > parser = argparse.ArgumentParser(description='user-space timerlat thread in > Python') > -parser.add_argument("cpu", help='CPU to run timerlat thread') > -parser.add_argument("-p", "--prio", help='FIFO priority') > - > +parser.add_argument("cpu", type=int, help='CPU to run timerlat thread') > +parser.add_argument("-p", "--prio", type=int, help='FIFO priority') > args = parser.parse_args() > > try: > - affinity_mask = { int(args.cpu) } > + affinity_mask = {args.cpu} > except: > print("Invalid cpu: " + args.cpu) > exit(1) > @@ -44,7 +43,7 @@ except: > > if args.prio: > try: > - param = os.sched_param(int(args.prio)) > + param = os.sched_param(args.prio) > os.sched_setscheduler(0, os.SCHED_FIFO, param) > except: > print("Error setting priority") > -- > 2.46.2 >
Reviewed-by: Tomas Glozar <[email protected]>
