On Tue,  1 Jul 2025 09:03:14 +0300
Costa Shulyupin <costa.s...@redhat.com> wrote:

> timerlat_params and osnoise_params structures contain 17 identical
> fields.
> 
> Introduce a common_params structure and move those fields into it to
> eliminate the code duplication and improve maintainability.

I have no preference about this patch, but would like an acked-by or
reviewed-by from Tomas and/or Gabriele.

Thanks,

-- Steve


> 
> Signed-off-by: Costa Shulyupin <costa.s...@redhat.com>
> ---
>  tools/tracing/rtla/src/osnoise.c       |  24 ++---
>  tools/tracing/rtla/src/osnoise.h       |  19 +---
>  tools/tracing/rtla/src/osnoise_hist.c  | 112 ++++++++++-----------
>  tools/tracing/rtla/src/osnoise_top.c   | 102 +++++++++----------
>  tools/tracing/rtla/src/timerlat.c      |  24 ++---
>  tools/tracing/rtla/src/timerlat.h      |  19 +---
>  tools/tracing/rtla/src/timerlat_bpf.c  |   4 +-
>  tools/tracing/rtla/src/timerlat_hist.c | 129 +++++++++++++------------
>  tools/tracing/rtla/src/timerlat_top.c  | 121 +++++++++++------------
>  tools/tracing/rtla/src/utils.h         |  31 ++++++
>  10 files changed, 292 insertions(+), 293 deletions(-)
> 

Reply via email to