Hello Steven Rostedt,

Commit e6187007d6c3 ("tracing/events: add startup tests for events")
from Apr 15, 2009 (linux-next), leads to the following Smatch static
checker warning:

        kernel/trace/trace_events.c:4704 event_test_stuff()
        error: 'test_thread' dereferencing possible ERR_PTR()

kernel/trace/trace_events.c
    4698 static __init void event_test_stuff(void)
    4699 {
    4700         struct task_struct *test_thread;
    4701 
    4702         test_thread = kthread_run(event_test_thread, NULL, 
"test-events");
    4703         msleep(1);
--> 4704         kthread_stop(test_thread);

Check for if (!IS_ERR(test_thread)) ?

    4705 }

regards,
dan carpenter

Reply via email to