Re: [PATCH v9 4/4] tracing: Add warnings for unused tracepoints for modules

[Steven Rostedt]

On Fri, 17 Oct 2025 22:22:32 +0200
Nicolas Schier <n...@kernel.org> wrote:

> On Wed, Oct 15, 2025 at 04:19:28PM -0700, Nathan Chancellor wrote:
> > Hi Steve,
> > 
> > On Wed, Oct 15, 2025 at 04:38:46PM -0400, Steven Rostedt wrote:  
> > > diff --git a/scripts/Makefile.modfinal b/scripts/Makefile.modfinal
> > > index 542ba462ed3e..6f909979af91 100644
> > > --- a/scripts/Makefile.modfinal
> > > +++ b/scripts/Makefile.modfinal
> > > @@ -28,6 +28,12 @@ ccflags-remove-y := $(CC_FLAGS_CFI)
> > >  .module-common.o: $(srctree)/scripts/module-common.c FORCE
> > >   $(call if_changed_rule,cc_o_c)
> > >  
> > > +ifneq ($(WARN_ON_UNUSED_TRACEPOINTS),"")  
> > 
> > Drop the "", nowhere else in Kbuild appears to do this.
> >   
> > > +cmd_check_tracepoint = ${objtree}/scripts/tracepoint-update $<;  
> > 
> > Please use $(objtree) to be consistent with the rest of Kbuild.
> >   
> > > +else
> > > +cmd_check_tracepoint =
> > > +endif  
> 
> The else part is not required, cp. definition of e.g. cmd_checkdoc in
> scripts/Makefile.build.

Thanks, will do.

-- Steve