On Thu, 30 Oct 2025 10:10:36 +0100 Tomas Glozar <[email protected]> wrote:
> Hi Steven, > > čt 2. 10. 2025 v 19:09 odesílatel Costa Shulyupin > <[email protected]> napsal: > > > > In recently introduced timerlat_free(), > > the variable 'nr_cpus' is not assigned. > > > > Assign it with sysconf(_SC_NPROCESSORS_CONF) as done elsewhere. > > Remove the culprit: -Wno-maybe-uninitialized. The rest of the > > code is clean. > > > > Signed-off-by: Costa Shulyupin <[email protected]> > > --- > > tools/tracing/rtla/Makefile.rtla | 2 +- > > tools/tracing/rtla/src/timerlat.c | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > This is another fix of a bug introduced in the 6.18-v1 RTLA code > consolidation [1], this time affecting the resetting of idle states > set through --deepest-idle-state. Could you please also add it to your > RTLA fix queue? > > Also, this should have: > > Fixes: 2f3172f9dd58 ("tools/rtla: Consolidate code between > osnoise/timerlat and hist/top") > > [1] > https://lore.kernel.org/linux-trace-kernel/[email protected]/T/ > Thanks, I'll take a look at this today. We need to start making you a maintainer for this, so that you only need to send me pull requests. Do you have a kernel.org account? If not, do you have PGP signatures from other kernel.org developers to your key? -- Steve
