On 05/26, Jiri Olsa wrote:
>
> In case the optimization fails, we leak new-ly created trampoline
> vma mapping (in case we just created it), let's unmap it.
>
> Fixes: ba2bfc97b462 ("uprobes/x86: Add support to optimize uprobes")
> Signed-off-by: Jiri Olsa <[email protected]>Reviewed-by: Oleg Nesterov <[email protected]> but I am a bit confused... It seems that this change doesn't depend on the previous 03/13 which removed VM_DONTCOPY ? So I think this patch could come as 3/13 after "Remove struct uprobe_trampoline object". And the subject looks misleading to me. A tramp vma may become "unused" if (say) we remove some optimized breakpoint, afaics it will be never unmapped. Perhaps it should say something like "don't leak on failure". But this all is really minor, please ignore. Oleg.
