Re: [PATCH 2/2] tracing/synthetic: Free type string on error path

[Yu Peng]

On 7/7/2026 1:15 AM, Steven Rostedt wrote:

Can you do this instead?

diff --git a/kernel/trace/trace_events_synth.c 
b/kernel/trace/trace_events_synth.c
index cdd5b9332835..7ff0f00edbdd 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -828,7 +828,7 @@ static struct synth_field *parse_synth_field(int argc, char 
**argv,
        } else if (size == 0) {
                if (synth_field_is_string(field->type) ||
                    synth_field_is_stack(field->type)) {
-                       char *type;
+                       char *type __free(kfree) = NULL;

len = sizeof("__data_loc ") + strlen(field->type) + 1;

                        type = kzalloc(len, GFP_KERNEL);
@@ -844,7 +844,7 @@ static struct synth_field *parse_synth_field(int argc, char 
**argv,
                        s.buffer[s.len] = '\0';

kfree(field->type);

-                       field->type = type;
+                       field->type = no_free_ptr(type);

field->is_dynamic = true;

                        size = sizeof(u64);

-- Steve

Yes, that looks better. I'll fold it into v2.

Thanks,
Yu Peng