Change type of `tft` and `rft` fields of `nmk_i2c_dev` structure from `unsigned char` to `u8` and `buffer` field of `i2c_nmk_client` structure from `unsigned char *` to `u8 *`.
Put two bool variables `xfer_done` and `has_32b_bus` and two u8 variables `tft` and `rft` together in order to reduce struct size wasted for padding. Signed-off-by: Dmitry Guzman <[email protected]> --- drivers/i2c/busses/i2c-nomadik.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index c3878670da9cfa462b66919ddc58b55cc78db6e5..45b4815b094524d9a8de69376e2933171541611a 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -170,7 +170,7 @@ enum i2c_operating_mode { struct i2c_nmk_client { unsigned short slave_adr; unsigned long count; - unsigned char *buffer; + u8 *buffer; unsigned long xfer_bytes; enum i2c_operation operation; }; @@ -187,13 +187,13 @@ struct i2c_nmk_client { * @clk_freq: clock frequency for the operation mode * @tft: Tx FIFO Threshold in bytes * @rft: Rx FIFO Threshold in bytes + * @xfer_done: xfer done boolean. + * @has_32b_bus: controller is on a bus that only supports 32-bit accesses. * @timeout_usecs: Slave response timeout * @sm: speed mode * @stop: stop condition. * @xfer_wq: xfer done wait queue. - * @xfer_done: xfer done boolean. * @result: controller propogated result. - * @has_32b_bus: controller is on a bus that only supports 32-bit accesses. */ struct nmk_i2c_dev { struct i2c_vendor_data *vendor; @@ -204,15 +204,15 @@ struct nmk_i2c_dev { struct clk *clk; struct i2c_nmk_client cli; u32 clk_freq; - unsigned char tft; - unsigned char rft; + u8 tft; + u8 rft; + bool xfer_done; + bool has_32b_bus; u32 timeout_usecs; enum i2c_freq_mode sm; int stop; struct wait_queue_head xfer_wq; - bool xfer_done; int result; - bool has_32b_bus; }; /* controller's abort causes */ -- 2.43.0
