When the mmiotrace trace was first created, it allocated a descriptor in its pipe_open() method. Since there was no pipe_close() method when it was created (in May of 2008, and pipe_close() was added in December of 2009), it cleaned up the allocated descriptors in the read.
Now that the clean up is in the pipe_close() method that now exists, remove the clean up from the read as it is no longer needed. Also simplify the code by inverting the early exit conditional into a conditional to perform the logic and get rid of the goto. Link: https://lore.kernel.org/all/[email protected]/ Link: https://lore.kernel.org/all/[email protected]/ Changse since v1: https://lore.kernel.org/linux-trace-kernel/[email protected]/ - Broke it up into two patches. Nothing else changed. Steven Rostedt (2): tracing: Do not clean up hiter in mmiotrace read function tracing: Invert the logic in mmio_read() to get rid of the goto ---- kernel/trace/trace_mmiotrace.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
