Sounds like a good idea to me! I'll try to look at how that lock is used. - Dave ----- Original Message ----- From: "Dunlap, Randy" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, February 26, 2001 5:58 PM Subject: RE: [linux-usb-devel] Re: [patch] ooops in 2.4.2-pre3 > Hi Dave- > > I can agree with your argument (about not exposing the > extern). I had put usb_bus_list_lock in usb.h because > that's where usb_bus_list and usb_driver_list are, > so probably they should also be moved out of usb.h -- > right? > > ~Randy_________________________________________ > > > > -----Original Message----- > > From: David Brownell [mailto:[EMAIL PROTECTED]] > > Sent: Monday, February 26, 2001 5:26 PM > > To: [EMAIL PROTECTED] > > Subject: Re: [linux-usb-devel] Re: [patch] ooops in 2.4.2-pre3 > > > > > > Hey -- nobody other than 'usbcore' should be touching > > that spinlock, right? if so, it shouldn't be in "usb.h". > > > > - Dave > > > > ----- Original Message ----- > > From: "Johannes Erdfelt" <[EMAIL PROTECTED]> > > To: "Randy.Dunlap" <[EMAIL PROTECTED]> > > Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> > > Sent: Monday, February 26, 2001 3:14 PM > > Subject: [linux-usb-devel] Re: [patch] ooops in 2.4.2-pre3 > > > > > > > On Thu, Feb 15, 2001, Randy.Dunlap <[EMAIL PROTECTED]> wrote: > > > > This patch adds a rw spinlock to uses of the usb_bus_list. > > > > It prevents an oops that occurred [occurs] when an HCD is > > > > deleting a bus and other USB core functions are traversing > > > > the bus list. > > > > > > > > It's just a gathering of one-liner patches. > > > > > > > > Comments? Otherwise please apply to 2.4.2. > > > > > > It looks good to me other than the missing extern declaration for > > > usb_bus_list_lock. > > > > > > I'll assume it was in include/linux/usb.h and make a new > > diff for Linus. > > > > > > JE > > > _______________________________________________ > [EMAIL PROTECTED] > To unsubscribe, use the last form field at: > http://lists.sourceforge.net/lists/listinfo/linux-usb-devel _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
