I have tested out the all the other settings in the char[] definition.
The
only value that need to change is the subaddress 0x08. All the other values
were ok.
I did have to re-adjust the input values so the output looked ok in usbvision.c.
We could possible just change the case statement. And use the replacement value
0xC8 for NTSC.
case DECODER_SET_NORM:
{
int *iarg = arg;
switch (*iarg) {
case VIDEO_MODE_NTSC:
saa7111_write(client, 0x08,
(decoder->
reg[0x08] & 0x3f) | 0x40);
break;
case VIDEO_MODE_PAL:
saa7111_write(client, 0x08,
(decoder->
reg[0x08] & 0x3f) | 0x00);
break;
case VIDEO_MODE_AUTO:
saa7111_write(client, 0x08,
(decoder->
reg[0x08] & 0x3f) | 0x80);
break;
default:
return -EINVAL;
}
decoder->norm = *iarg;
}
break;
Or we could just add a if statement to change the default value within char
init[].
Jörg Heckenbach <[EMAIL PROTECTED]> on 04/12/2001 08:45:37 AM
Please respond to [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
cc: (bcc: Dwaine Garden/ISD/WCBO)
Subject: Re: [linux-usb-devel] USBVISION: Parameters in saa7111-new.c
Sorry, I forgot to attach the saa7111-new.c.
Here it is.
> a) 0x08 subaddress with value 0x08 is causing the black & white display.
> if I change this value back to the original value of 0xc8 then the colour
> comes back.
OK. That's no problem to me. Bit 7 enables the automatic field
detection.
> b) 0x06 subaddress with value 0xf6 change the position at the right side
> of the video window. I get a huge black line. It's really bad.
That's a problem. My device often hangs with this value. I don't know
why. But it runs
more stable with 0XEC. It would be nice if you could use the same value
and adjust the horizontal position by usbvision_set_input. Otherwise we
must just if-clauses ;)
Joerg.
saa7111-new.c
