> @@ -181,7 +181,9 @@
>   dma_addr_t dma_handle;
>   struct uhci_td *td;
>  
> - td = pci_pool_alloc(uhci->td_pool, GFP_DMA | GFP_ATOMIC, &dma_handle);
> + /* pci_pool uses pci_alloc_consistent() which adds GFP_DMA if required */
> +
> + td = pci_pool_alloc(uhci->td_pool, GFP_ATOMIC, &dma_handle);
>   if (!td)
>   return NULL;
>  

... actually pci_pool_alloc() takes only SLAB_ATOMIC
or SLAB_KERNEL (equivalent to GFP_*), so GFP_DMA
is illegal in any case.  Those particular changes should certainly
get integrated, though I'd make them say SLAB_* just to
be nit-pickey.

- Dave




_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to