But was it the same oops as before, or a different one?

Can you modify that new "default" case in usblp_write()
to say what error got reported, through dbg() or somesuch?

- Dave

----- Original Message ----- 
From: "Anders S. Buch" <[EMAIL PROTECTED]>
To: "David Brownell" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Friday, May 18, 2001 9:08 AM
Subject: Re: [linux-usb-devel] Bug report


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi David,
> 
> Thanks a lot for your help!  Your latest patch behaves exactly the same as
> the previous one, i.e. I get a flood of
> 
> printer.c: usblp0: failed reading printer status
> 
> Again, rmmod usb-ohci stops the message flood, and also produces an oops.
> 
> Sincerely, Anders
> 
> 
> > Thanks for testing this, Anders!
> >
> > > I did my usual "cat /boot/bzImage > /dev/usb/lp0" immediately after
> > > turning my printer off, which usually results in an oops and a kernel
> > > lockup.  With David's patch, however, the kernel just got busy
> > > printing the line over and over again:
> > >
> > > printer.c: usblp0: failed reading printer status
> >
> > Looks like usblp_write() line 402 should verify the printer is still
> > present before calling usblp_check_status and looping.  That
> > also explains why unplug/replug did nothing:  It's holding the
> > semaphore that usblp_disconnect() needs to get to do its job,
> > tying up khubd...
> >
> >
> > > rmmod usbcore printer usb-ohci
> > >
> > > Besides from stopping the error messages, this also produced an oops,
> > > see the data below about this.
> >
> > Which fingers that same bad usblp_check_status() call.
> >
> > Updated patch attached.  That usblp_write() routine looks iffier to me
> > the more I look at it ...
> >
> > - Dave
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.5 (SunOS)
> Comment: For info see http://www.gnupg.org
> 
> iD8DBQE7BUkLWyfD6jrb5n4RAridAJ9144ZLnkkzeApr8wlWiP8eEKGXugCeOdUz
> 0x+pHrVDMUzdUlPmsjv8drk=
> =ocs1
> -----END PGP SIGNATURE-----
> 


_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to