On Sat, Oct 20, 2001, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > On Fri, 19 Oct 2001, Greg KH wrote: > > > > Here's a patch against 2.4.13-pre5 that fixes a compiler warning in > > the uhci.c driver. > > Well, it also seems to change what the code does. Before, the '&&' was the > stronger one due to C operator precedence rules, and now you'e added the > parenthesis around the '||', thus changing the meaning of the code. > > Which one is correct (if the new one, please don't call the patch 'fixing > a compiler warning')?
The patch is correct. The old code would almost always run correctly. The only case it would fail would be if we removed an URB which had no TD's retired and it had an odd number of TD's. So, it's not just fixing a compiler warning, but it fixes a rare bug. JE _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
