On Sun, Jan 20, 2002 at 04:55:12PM -0800, David Brownell wrote:
> > One other comment, it looks like you got the "Product=" and
> > "Manufacturer=" lines in /proc/bus/usb/devices backwards :)
>
> It agrees with the EHCI driver ... that's handled in "hcd.c",
> function rh_string().
>
> Manufacturer = Linux 2.5.3 <drivername>
> Product = the PCI product description
>
> That could get switched, I suppose, but it seems right to me
> that the manufacturer of this virtual hub be the kernel. Feel
> free to reverse those values if you feel strongly.
This differs from the existing uhci.c, usb-ohci.c, and usb-uhci.c
drivers, which just implement the Product line.
I'd say to switch them in hcd.c, as the manufacturer of the USB card
shows up in the Product line with the hcd code, which might confuse
people (it confused me :)
For example, the ohci-hcd driver shows the following:
S: Manufacturer=Linux 2.5.3-pre2 ohci-hcd
S: Product=LSI Logic / Symbios Logic (formerly NCR) 61C102
While uhci.c just shows the product:
S: Product=USB UHCI-alt Root Hub
thanks,
greg k-h
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
