On Tue, Apr 02, 2002 at 07:56:40PM -0800, Mark McClelland wrote: > Greg KH wrote: > > >I think the network and video drivers now have a critical mass to move > >them to their own directory if no one objects. Nice thing about > >bitkeeper, file moves are very simple to do :) > > > > Should they be moved to drivers/net and drivers/media/video instead? I > mean, no one would think to look for the tulip driver under > drivers/pci/net. Then again, I'd hate to lose you as my upstream > maintainer ;-)
If you want to move your driver to that directory, feel free. The previous main reason to stay in the USB subdirectory was due to link order and initialization. On 2.4 and 2.5, the USB subsystem starts up pretty late, and the USB drivers after that. If you are in a different directory, you could accidentally call some of the usb_* functions before the subsystem was enabled, causing bad things to happen. With 2.5 this is now fixed, and the USB core is started up pretty early. This was driven due to the placement of USB drivers outside of the drivers/usb directory :) Personally I like the drivers to be in the drivers/usb directory because the USB subsystem logic is usually greater than the other subsystem is (whatever the device type the driver is.) It also enables things like changing USB apis to be done easier. > Incidentally, I'm about to split ov511.c into ~10 files to simplify > maintenance. That would almost have critical mass for its own directory > (the same might be said for pwc). Yes, 10 files would deserve it's own directory. I'll propose a new directory structure tomorrow, which everyone can disagree with :) > I just looked at RedHat's 2.4.9-31 kernel, and was surprised to see that > they have already given ov511 its own directory (under drivers/usb). It > even has a Makefile of its own, to work around a stupid gcc bug. Ah, didn't realize that. They also have the very nice addon directory for drivers that live outside of the main kernel tree. thanks, greg k-h _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
