>       By the way, I have looked at the code for alloc_skb in
> linux-2.5.8-pre1/net/core/skbuff.c and have no idea how this can
> help alignment.  Also, to my knowledge, all USB host controllers
> do DMA (I mean PCI bus mastering, not using the motherboard's DMA
> controllers).  The driver seems to work fine without the skb_reserve
> calls.
>       So, please delete them if you have not done so already.  Thanks
> in advance.

And then please put them back again when Adam rereads the code 8)

alloc_skb will always get an skb->data object that is 4 byte aligned. The
reserve adds 2 bytes. This places the ethernet header at

        allocation base                 0
        skb->data starts                16
        skb->data after adjust          18
        IP header starts                32

Neatly landing the IP header on a cache line start for most processors

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to