On Mon, Apr 08, 2002 at 10:34:41AM -0700, David Brownell wrote:
> > > >     - adds ethtool support (based on code from Brad Hards)
> > > >     - makes diagnostic level configurable (ethtool, module param)
> > > >     - fixes a minor mem_flags goof (thanks Oliver!)
> > 
> > Um, could we let some people have a chance to test these new features
> > out first on 2.5 before applying this to 2.4?
> 
> Hmm, what kind of feedback would you be expecting?  It works
> on 2.4 just like on 2.5 ... and I'd really not have to make the 2.4
> version diverge any more than absolutely necessary.

I understand, but how about a simple "works for me" from a user who is
not the developer :)

> I tend to count "doesn't support ethtool" as minor bugfix, in any
> case.  The ethtool manage lists incomplete driver support as
> the notable BUG ... :)

I agree.

> > It looks like there are some bugfixes in this patch, which I would be
> > glad to apply to 2.4 right now if you want to make up a patch just
> > containing them.
> 
> Just the one GFP_NOIO thing (a couple lines), but I'd rather not
> create excess divergence.  It'll just make more work creating a
> later backport patch ... the change history will make no sense! :)
> 
> Better to just hold this patch for a short while.

I'd be more than willing to put this patch in my 2.4 tree, but not send
it on to Marcelo until 2.4.19-final comes out.  Should I do that?  Makes
it easier for you, and keeps your change history sane :)

thanks,

greg k-h

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to