Hrm... okay, what's the best BK way to handle this? Do I generate a new changeset to fix this, or go back into an older tree and generate a different solution/changeset?
Matt On Sun, May 26, 2002 at 11:19:33PM -0700, Greg KH wrote: > On Sat, May 25, 2002 at 05:44:07PM -0700, Matthew Dharm wrote: > > Second ChangeSet. Here goes nothing... > > > > # This is a BitKeeper generated patch for the following project: > > # Project Name: greg k-h's linux 2.5 USB kernel tree > > # This patch format is intended for GNU patch command version 2.5 or higher. > > # This patch includes the following deltas: > > # ChangeSet 1.562 -> 1.563 > > # drivers/usb/storage/debug.h 1.1 -> 1.2 > > # > > # The following is the BitKeeper ChangeSet Log > > # -------------------------------------------- > > # 02/05/25 [EMAIL PROTECTED] 1.563 > > # Fix a compilation error -- ASSERT() isn't defined globally in the > > # kernel. Perhaps it should be.... > > No. Please go see the lkml archives about why Linus doesn't want an > ASSERT() macro in the kernel. > > And what you're doing here really isn't an ASSERT macro, as you aren't > halting what you were doing. If you want to do something like this, use > the existing BUG_ON() statement. > > So I'll hold off on applying this one, and your previous patch (which > were generated and sent off just fine. Nice job with bitkeeper.) > > thanks, > > greg k-h > > _______________________________________________________________ > > Don't miss the 2002 Sprint PCS Application Developer's Conference > August 25-28 in Las Vegas -- http://devcon.sprintpcs.com/adp/index.cfm > > _______________________________________________ > [EMAIL PROTECTED] > To unsubscribe, use the last form field at: > https://lists.sourceforge.net/lists/listinfo/linux-usb-devel -- Matthew Dharm Home: [EMAIL PROTECTED] Maintainer, Linux USB Mass Storage Driver THEY CASTRATED MY QUAKE BITS! I WANT THEM BACK!!!! -- Greg User Friendly, 3/27/1998
msg06828/pgp00000.pgp
Description: PGP signature
