On Mon, Jul 22, 2002 at 02:03:52AM -0700, Christopher Hoover wrote:
> This version doesn't oops and is perspicuous.
>
> I haved tested it in the "both strings" case (which made the old code
> oops) and in the "no strings" case.
>
> -ch
> [EMAIL PROTECTED]
> [EMAIL PROTECTED]
>
>
> --- linux-2.5.26-rmk1/drivers/usb/core/usb.c Tue Jul 16 16:49:34 2002
> +++ linux-2.5.26-rmk1-ch1/drivers/usb/core/usb.c Mon Jul 22 01:50:08 2002
> @@ -1221,56 +1221,59 @@ int usb_set_address(struct usb_device *d
> */
> static void set_device_description (struct usb_device *dev)
> {
> - char *buf, *here, *end;
> - int mfgr = dev->descriptor.iManufacturer;
> - int prod = dev->descriptor.iProduct;
> + void *buf;
> + int iMfgr = dev->descriptor.iManufacturer;
> + int iProd = dev->descriptor.iProduct;
> + int idVendor = dev->descriptor.idVendor;
> + int idProduct = dev->descriptor.idProduct;
> + char *sMfgr, *sProd;
Eeek, no! I will not take new patches for MixedCase variables, sorry.
It's bad enough that the USB spec states them for a number of the field
names, I can live with that, but will not tolerate them for local
variables. It's just not proper kernel programming style.
And what exactly is this patch trying to fix? What is wrong with the
existing code? Do you have a specific device that this patch fixes?
thanks,
greg k-h
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
