There have been several patches around "fixing" one-shot interrupt URBs
lately. With the help of David Brownell, I've made a "fixed" version of
the fix and included it in the PowerMac stable tree (2.4.20-ben3). I'm
about to push it to the main PPC bk trees as well.

For those interested, here I copied it below. Depending on the feedback
I get about this patch, I'll back it out or submit it for inclusion
in Marcelo's official tree.

--- 1.30/drivers/usb/usb-ohci.c Tue Jan  7 11:52:53 2003
+++ edited/drivers/usb/usb-ohci.c       Sun Jan 26 20:26:54 2003
@@ -490,12 +490,16 @@
                                usb_pipeout (urb->pipe)
                                        ? PCI_DMA_TODEVICE
                                        : PCI_DMA_FROMDEVICE);
-                       urb->complete (urb);
-
+                       if (urb->interval == 0) {
+                               urb_rm_priv (urb);
+                               urb->complete (urb);
+                               break;
+                       }
                        /* implicitly requeued */
-                       urb->actual_length = 0;
-                       urb->status = -EINPROGRESS;
-                       td_submit_urb (urb);
+                       urb->complete (urb);
+                       urb->actual_length = 0;
+                       urb->status = -EINPROGRESS;
+                       td_submit_urb (urb);
                        break;
    

-- 
Benjamin Herrenschmidt <[EMAIL PROTECTED]>


-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to