On Thu, Jan 23, 2003 at 09:41:17PM +0100, Duncan Sands wrote: > speedtouch: recycle the receive urb's buffer. Currently, every time a receive urb > completes, its old buffer is thrown away and replaced with a new one. This patch > performs the minor changes needed to reuse the old buffer. We need a copy of the > sk_buff on the stack because atmsar_decode_rawcell mucks around with the data and > tail pointers. I'll fix atmsar_decode_rawcell some other day (or should I say >night). > > > speedtouch.c | 39 ++++++++++++++++++--------------------- > 1 files changed, 18 insertions(+), 21 deletions(-) > > > diff -Nru a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c > --- a/drivers/usb/misc/speedtouch.c Thu Jan 23 21:39:09 2003 > +++ b/drivers/usb/misc/speedtouch.c Thu Jan 23 21:39:09 2003 > @@ -348,9 +348,10 @@ > struct udsl_instance_data *instance = (struct udsl_instance_data *) data; > struct udsl_data_ctx *ctx; > unsigned long flags; > + struct sk_buff skb;
Ick, no, I will not take this patch, sorry. That's just too much data on the stack. Try using skb_clone() or friends if you need a temp copy of the skb. thanks, greg k-h ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
