Greg: As a result of a recently-applied change, there are two new subclass and protocol codes for the usb-storage unusual_devs.h file. The codes are US_SC_DEVICE and US_PR_DEVICE; their meaning is that the driver should use whatever value the device supplies instead of overriding it.
There are probably lots of entries that could be changed to use the new codes. Unfortunately, with only a few exceptions we don't know which ones they are! Code has been added to the driver to check during probe() whether the entry contains an unneeded subclass or protocol override. When such an entry is found, the driver prints a log message giving the details and asking the user to send the information to linux-usb-devel. In this way we hope to accumulate a list of devices for which the existing overrides can safely be removed. The reason for doing all this is so that we can delete no-longer needed entries from the unusual_devs list. Clearly, an entry isn't needed if it contains no special flags and it doesn't override the device's settings. That's what the new codes will tell us. This means that when a patch for a new unusual_devs.h entry is accepted, we should always make sure it specifies US_SC_DEVICE or US_PR_DEVICE whenever possible. That's the reason for asking the submitter to send a copy of /proc/usb/devices along with the patch: to verify whether the entry really needs to override the subclass/protocol or not. I'll go through the mailing list archives for the last couple of months to find recent submissions that can be changed. In the future, you can just ask the submitters to make the appropriate changes themselves. By the way, this change has only been made in 2.5. A lot of people submit new entries for 2.4 -- there doesn't seem to be any reason not to back-port the new codes so that unusual_devs.h can remain consistent between the two versions. I'll work on that too. Alan Stern On Wed, 18 Jun 2003, Greg KH wrote: > ChangeSet 1.1318.4.11, 2003/06/17 14:38:38-07:00, [EMAIL PROTECTED] > > [PATCH] USB: Patch for Vivicam 355 > > > drivers/usb/storage/unusual_devs.h | 8 ++++++++ > 1 files changed, 8 insertions(+) > > > diff -Nru a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h > --- a/drivers/usb/storage/unusual_devs.h Wed Jun 18 11:14:49 2003 > +++ b/drivers/usb/storage/unusual_devs.h Wed Jun 18 11:14:49 2003 > @@ -391,6 +391,14 @@ > US_SC_SCSI, US_PR_BULK, NULL, > US_FL_FIX_INQUIRY | US_FL_MODE_XLATE), > > +/* Reported by Hanno Boeck <[EMAIL PROTECTED]> > + * Taken from the Lycoris Kernel */ > +UNUSUAL_DEV( 0x0636, 0x0003, 0x0000, 0x9999, > + "Vivitar", > + "Vivicam 35Xx", > + US_SC_SCSI, US_PR_BULK, NULL, > + US_FL_FIX_INQUIRY | US_FL_MODE_XLATE), > + > UNUSUAL_DEV( 0x0644, 0x0000, 0x0100, 0x0100, > "TEAC", > "Floppy Drive", ------------------------------------------------------- This SF.Net email is sponsored by: INetU Attention Web Developers & Consultants: Become An INetU Hosting Partner. Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission! INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
