Hi,
usually this would be too trivial, but is so obviously stupid that
people might think that there's some hidden trick in there.
We should not check for NULL _after_ following a pointer.
Consider it a small tiny step towards cleaning up this code.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2003-10-04 23:46:36+02:00, [EMAIL PROTECTED]
- no need to test for NULL, we'd have already oopsed
devio.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nru a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
--- a/drivers/usb/core/devio.c Sat Oct 4 23:48:38 2003
+++ b/drivers/usb/core/devio.c Sat Oct 4 23:48:38 2003
@@ -384,7 +384,7 @@
err = -EINVAL;
dev = ps->dev;
down(&dev->serialize);
- if (dev && test_and_clear_bit(intf, &ps->ifclaimed)) {
+ if (test_and_clear_bit(intf, &ps->ifclaimed)) {
iface = dev->actconfig->interface[intf];
usb_driver_release_interface(&usbdevfs_driver, iface);
err = 0;
===================================================================
This BitKeeper patch contains the following changesets:
1.2487
## Wrapped with gzip_uu ##
begin 664 bkpatch12060
M'XL(`#9`?S\``\64;6O;,!#'7T>?XJ"PM;2V]63',:1D:\<V%K:0+:^#;9UC
[EMAIL PROTECTED]@\_Q8%F+6G9NA<3$A([EMAIL PROTECTED])AKH3;[EMAIL PROTECTED];:&#'
M9:NP<BMLUVWI:K.RMKG6UN;END3OX.#],(BUU]:)PUV?V#6SN$ESL*8Z&C!7
M/,PT]UN,!O,/'Q?3=W-"QF.XR>[EMAIL PROTECTED]&8).N):G'CKHV.\_UQW8.YXY0R
MQKA/A1\PO^.A$+)C`4V4'2H^'&5),"([EMAIL PROTECTED])P3W5Y6-WP6SC0G`>=%)P/R2W
MP%PNPR%0X3'J40E<1#*(1'!)>40I'/*;G!`"+ADXE+R'[EMAIL PROTECTED]
M:&BP;B#3!KXNIM,KN,.W"O)XAQ!O#,;J'K3>UJC(%Y#2YY+,CBH2YR\+(32F
MY/I$&LKL<^^OU5.X*[2;'A.2=,2&'0OE,.Q\GC',!&<)1YHP\8)JCS9-M<'?
M=][?C^1,!MSO)+5:]8`\YW&:EU<'_92<%P.E(0O84(9^V$G&1[P'*11/,>+^
MGV'$_CM&O=K?P#%W?;58S)X5_A6(W0K[QACY?.@&10;G^^"6<:66Z09CLTR*
MYKRHFNP*WFQKY[K(TDU<[EMAIL PROTECTED])<TS7=5N.U2A.[!/FY!="_Y([EMAIL PROTECTED]
!````
`
end
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
