Am Dienstag, 7. Oktober 2003 22:10 schrieb David Brownell:
>         case USBDEVFS_CONNECT:
> -               lock_kernel();
> +               down_write(&ifp->dev.bus->subsys.rwsem);
>                 retval = usb_probe_interface (&ifp->dev);
> -               unlock_kernel();
> +               up_write(&ifp->dev.bus->subsys.rwsem);
>                 break;

Hi,

it seems to me, although this is not a fault of your patch, but
an existing bug, that this can be used to probe an already
claimed interface.
Shouldn't it rather be

down_write(&ifp->dev.bus->subsys.rwsem);
if (ifp->dev.driver) {
        retval = -EBUSY;
} else {
        retval = usb_probe_interface (&ifp->dev);
}
up_write(&ifp->dev.bus->subsys.rwsem);

        Regards
                Oliver



-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to