Am Dienstag, 7. Oktober 2003 22:10 schrieb David Brownell:
>         default:
> -               /* BKL used here to protect against changing the binding
> -                * of this driver to this device, as well as unloading its
> -                * driver module.
> -                */
> -               lock_kernel ();
> -               driver = ifp->driver;
> -               if (driver == 0 || driver->ioctl == 0) {
> -                       unlock_kernel();
> +               down_read(&ifp->dev.bus->subsys.rwsem);

This is potentially dangerous. This code ran under BKL previously.
To keep the locking consistent with 2.4, could you use down_write()
here?. It is a little late to audit this handlers against reentrancy.

        Regards
                Oliver




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to