Hi Folks !

There's a small issue with drivers/usb/serial/keyspan_usa90msg.h

The definition for MSR_RI conflicts with some PowerPC CPU definition
(MSR is the Machine State Register on PPC and processor.h defines
MSR_RI globally). This definition doesn't seem to be used in any .c
in drivers/usr/serial though, so I beleive it could be easily renamed
to something a bit less prone to conflict ;) Changing the PPC definition
would be a lot nastier.

I noticed that one of the other serial drivers in there was already
modified for that exact same change (turning MSR_RI into something
a bit more "complex").

Below is an example patch.

Regards,
Ben.

===== drivers/usb/serial/keyspan_usa90msg.h 1.1 vs edited =====
--- 1.1/drivers/usb/serial/keyspan_usa90msg.h   Fri Oct  3 18:21:11 2003
+++ edited/drivers/usb/serial/keyspan_usa90msg.h        Sat Oct 11 18:07:58 2003
@@ -182,14 +182,14 @@
 
 // MSR bits
 
-#define MSR_dCTS                       0x01            // CTS has changed since last 
report    
-#define MSR_dDSR                       0x02
-#define MSR_dRI                                0x04
-#define MSR_dDCD                       0x08
+#define USA_MSR_dCTS                   0x01            // CTS has changed since last 
report    
+#define USA_MSR_dDSR                   0x02
+#define USA_MSR_dRI                    0x04
+#define USA_MSR_dDCD                   0x08
 
-#define MSR_CTS                                0x10            // current state of CTS
-#define MSR_DSR                                0x20
-#define MSR_RI                         0x40
+#define USA_MSR_CTS                    0x10            // current state of CTS
+#define USA_MSR_DSR                    0x20
+#define USA_USA_MSR_RI                 0x40
 #define MSR_DCD                                0x80
 
 // ie: the maximum length of an endpoint buffer




-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to