On Sun, Oct 12, 2003 at 09:44:44AM +0200, Benjamin Herrenschmidt wrote: > On Sun, 2003-10-12 at 05:59, Greg KH wrote: > > On Sat, Oct 11, 2003 at 06:10:14PM +0200, Benjamin Herrenschmidt wrote: > > > Hi Folks ! > > > > > > There's a small issue with drivers/usb/serial/keyspan_usa90msg.h > > > > > > The definition for MSR_RI conflicts with some PowerPC CPU definition > > > (MSR is the Machine State Register on PPC and processor.h defines > > > MSR_RI globally). This definition doesn't seem to be used in any .c > > > in drivers/usr/serial though, so I beleive it could be easily renamed > > > to something a bit less prone to conflict ;) Changing the PPC definition > > > would be a lot nastier. > > > > > > I noticed that one of the other serial drivers in there was already > > > modified for that exact same change (turning MSR_RI into something > > > a bit more "complex"). > > > > > > Below is an example patch. > > > > Patch is fine with me. Care to send me a complete one? > > Complete ? Nothing is using those MSR_* things it seems, so the patch > as-is is fairly complete ;) Or did I miss something ?
No, I thought the driver actually used these fields. I'll apply this patch. thanks, greg k-h ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
