On Mon, 12 Jan 2004 10:53:03 -0500 (EST)
Alan Stern <[EMAIL PROTECTED]> wrote:

> > +++ b/drivers/usb/usb.c     Mon Jan 12 00:27:37 2004
> > @@ -1198,7 +1198,7 @@
> >  int usb_control_msg(struct usb_device *dev, unsigned int pipe, __u8 request, __u8 
> > requesttype,
> >                      __u16 value, __u16 index, void *data, __u16 size, int timeout)
> >  {
> > -   struct usb_ctrlrequest *dr = kmalloc(sizeof(struct usb_ctrlrequest), 
> > GFP_KERNEL);
> > +   struct usb_ctrlrequest *dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_NOIO);
> >     int ret;


> > @@ -1958,7 +1958,7 @@
> >     if (result < 0)
> >             return result;
> >  
> > -   buffer = kmalloc(sizeof(status), GFP_KERNEL);
> > +   buffer = kmalloc(sizeof(status), GFP_NOIO);
> >     if (!buffer) {

> Note that these changes have essentially already been incorporated into 
> 2.6, so only 2.4 needs updating.

Fine by me, too.

I am wondering though if it might make sense to have these things externally
allocated, that is, make outside requestors pass usb and usb_ctrlrequest
as arguments.

-- Pete


-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to