On Mon, Jan 12, 2004 at 09:42:05PM -0800, Randy.Dunlap wrote:
> -static int pwc_video_release(struct video_device *vfd)
> +static void pwc_video_release(struct video_device *vfd)
> {
> Trace(TRACE_OPEN, "pwc_video_release() called. Now what?\n");
> }
No, this function _really_ needs to be fixed properly. I told the
author about it months ago, and have got no response.
Memory needs to be freed up in this function. If not it will either
leak, or we can easily oops the machine (due to the driver not
implementing reference counting properly).
If I accept this patch, odds are no one will remember to go back and fix
this problem.
thanks,
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
