Hello,
On Tuesday 13 January 2004 18:41, Greg KH wrote:
> On Mon, Jan 12, 2004 at 09:42:05PM -0800, Randy.Dunlap wrote:
> > -static int pwc_video_release(struct video_device *vfd)
> > +static void pwc_video_release(struct video_device *vfd)
> > {
> > Trace(TRACE_OPEN, "pwc_video_release() called. Now what?\n");
> > }
>
> No, this function _really_ needs to be fixed properly. I told the
> author about it months ago, and have got no response.
I do not recall such a message... but I may just have overlooked it. If you
can give me a hint as to what must be done, I'll fix it, no problems.
> Memory needs to be freed up in this function. If not it will either
> leak, or we can easily oops the machine (due to the driver not
> implementing reference counting properly).
Hmm, that raises the question: which device gets removed first on unplug?
the usb_device or the video_device? This has been indeed quite difficult to
fix in the past, as either device could disappear any time. If this solved
that problem, only the better.
Unfortunately, I've had very little time to keep up to date with the
linux-usb-devel list, so I'm not familair with these fundamentel driver
changes. Mea culpa.
- Nemosoft
--
Linux Philips webcam driver page: http://www.smcc.demon.nl/webcam/
Includes FAQs, links to working programs and lots of info.
-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
