On Sat, 2004-03-06 at 04:32, David Brownell wrote:Benjamin Herrenschmidt wrote:
- Move the pmac specific PM bits where they should be (hcd-pci.c)
Could you hang those into a separate HCD level hook, instead? Right now these would kick in with, for example, an EHCI card... where they should certainly never kick in!
I want them to kick in on everything. The pmac platform code will take care of doing the right thing. (There is an on-board EHCI on G5s for example that I might be able to power control too)
NEC EHCI 1.0, or so I'm told. Standard PCI PM procedures should work for that. If they really can't, then maybe you should work this issue separately with Greg?
Let me know if you think I should remove the old bits, even if that new stuff isn't ready yet. I don't think anyone will object to removing #ifdefs!
Don't remove the old bits without adding the new ones, that would have the net effect of breaking sleep mode on PowerBooks.
You're saying it works today ... why change it?
I prefer moving that logic from ohci to hcd core. I'll do things better at one point using the power tree, but probably not before 2.7.
Thing is, up till now only HCDs have had platform-specific code. Why should usbcore have such a thing?
If such code doesn't belong in the HCD, I'd think the driver core is the place for it.
- Add a fix for a crash that I had when the HCD died
That finish_unlinks()? That can't have worked as you sent it, "ed" undefined means "ed->state" likely to oops ... it's probably the right thing to have further on down.
I think you sent me that patch a while ago :) I noticed it when
diff'ing, but let's just drop it if you think it's wrong.
It'd be OK several lines further down... I was hoping someone would test that change (more than "it compiles without warnings", which it didn't).
- Dave
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
