> NEC EHCI 1.0, or so I'm told. Standard PCI PM procedures > should work for that. If they really can't, then maybe > you should work this issue separately with Greg?
Looks like, but it's inside an Apple ASIC I think, which probably means additional stuff, I have to look in Darwin to be sure. Anyway, there is no problem callign the pmac hooks for any controller, they'll do the right thing. > >>Let me know if you think I should remove the old bits, even if > >>that new stuff isn't ready yet. I don't think anyone will > >>object to removing #ifdefs! > > > > > > Don't remove the old bits without adding the new ones, that would > > have the net effect of breaking sleep mode on PowerBooks. > > You're saying it works today ... why change it? It works today on most machines yes. But it's luck, the call we do from hcd-pci.c to pci_set_power_state (dev, state) _after_ the ohci-pci.c code shut the chip clock off is wrong. It happens to not lockup some of the machines, but I'm not confident it will work when I finally get sleep working on some more recent models. The call to pmac_feature should be the very last thing done to the chip on the suspend path and very first thing on the resume path. That code is shielded in #ifdef's so it won't affect anything else, please move it and let's be done with it, I don't understand why we argue forever on that unimportant shit. > > I prefer moving that logic from ohci to hcd core. I'll do things better > > at one point using the power tree, but probably not before 2.7. > > Thing is, up till now only HCDs have had platform-specific > code. Why should usbcore have such a thing? > > If such code doesn't belong in the HCD, I'd think the driver > core is the place for it. Well, you are mixing nice beautiful school design with the horrors of raw reality. > It'd be OK several lines further down... I was hoping > someone would test that change (more than "it compiles > without warnings", which it didn't). All I can say at this point is that the controller dying case no longer cause a crash with this version. Ben. ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
