On Fri, Apr 09, 2004 at 12:33:01AM +0200, Marcel Holtmann wrote: > Hi Greg, > > > > many thanks for looking at the problem. I am not an expert when it comes > > > to USB internals, but from your explanation I ask myself why we don't > > > have an unlink function that will wait until the last reference to the > > > URB is gone. Why do we have to do it in the driver itself? > > > > As you are handling the urb allocation logic yourself, this is a side > > affect from that. If you use usb_free_urb() and usb_alloc_urb() you > > will never see this problem, as the reference counting logic will handle > > it all for you automatically. > > > > I did warn you that you need to be careful when doing what you are > > trying to do :) > > actually you warned Max, because I don't wrote that part of the code.
Oops, sorry. It was a while ago :) > I also remember a long discussion about how we may better integrate > the SKB's as buffer for the URB's, but it seems that nobody has done > any code so far. Are there any improvements in 2.6 that I am not aware > of? Not that I am aware of either. I still think you all shouldn't be creating your own urbs though. I guarentee it will come back to bother you sometime in the future (no I don't have anything in the plan, it's just that you are the only driver doing this, and are tied very tightly to how the USB core works.) thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
