Hi,
Here's a patch against 2.6.6-rc2 that replaces the use of atomic_t in the ehci driver with a kref. It builds for for me here, any objections to me adding it to the main kernel tree?
Looks like a nice update, but it didn't build for me:
CC [M] drivers/usb/host/ehci-hcd.o In file included from drivers/usb/host/ehci-hcd.c:135: drivers/usb/host/ehci.h:371: field `kref' has incomplete type drivers/usb/host/ehci.h:389: confused by earlier errors, bailing out make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1 make[2]: *** [drivers/usb/host] Error 2 make[1]: *** [drivers/usb] Error 2 make: *** [drivers] Error 2
Maybe you have some extra patches, beyond RC2? (I know I did, but they didn't change header usage in EHCI.) The fix was just to explicitly include <linux/kref.h> ...
Adding that extra pointer to "qh" doesn't change its allocated size, at least on a K7. It looks "obviously correct", and passed basic sanity tests. Feel free to merge ... though please change qh_put() to an inline now that it's just one function call.
- Dave
------------------------------------------------------- This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek For a limited time only, get FREE Ground shipping on all orders of $35 or more. Hurry up and shop folks, this offer expires April 30th! http://www.thinkgeek.com/freeshipping/?cpg=12297 _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
