On Tue, Apr 27, 2004 at 01:04:05PM -0700, David Brownell wrote: > Greg KH wrote: > >Hi, > > > >Here's a patch against 2.6.6-rc2 that replaces the use of atomic_t in > >the ehci driver with a kref. It builds for for me here, any objections > >to me adding it to the main kernel tree? > > Looks like a nice update, but it didn't build for me: > > CC [M] drivers/usb/host/ehci-hcd.o > In file included from drivers/usb/host/ehci-hcd.c:135: > drivers/usb/host/ehci.h:371: field `kref' has incomplete type > drivers/usb/host/ehci.h:389: confused by earlier errors, bailing out > make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1 > make[2]: *** [drivers/usb/host] Error 2 > make[1]: *** [drivers/usb] Error 2 > make: *** [drivers] Error 2 > > Maybe you have some extra patches, beyond RC2? (I know I did, > but they didn't change header usage in EHCI.) The fix was just > to explicitly include <linux/kref.h> ...
I do have extra patches, the ones I've told the list I've applied, and a new one that switches struct urb to use a kref instead of its own atomic_t. That is the one that adds kref.h to usb.h and fixes your build issue :) > Adding that extra pointer to "qh" doesn't change its allocated > size, at least on a K7. It looks "obviously correct", and > passed basic sanity tests. Feel free to merge ... though please > change qh_put() to an inline now that it's just one function call. Ok, will do. thanks for verifying it. greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
