Greg KH wrote:
> On Sun, May 16, 2004 at 04:05:40PM -0400, Adam Kropelin wrote:
>> +/* Ick. hiddev.h needs hid.h which needs input.h */
>> +#include <linux/input.h>
>> +#include <../drivers/usb/input/hid.h>
>> +#include <linux/hiddev.h>
>
> Ick, does hiddev really need hid.h?

Yep, it needs HID_MAX_USAGES from hid.h ever since hiddev_usage_ref_multi
was added (which I think was fairly recently).

> If so, then we need to move it to include/linux/.

I'll whip up a patch if you'd like, or let you do a bk move, as you prefer.

While we're at it, should hid.h be changed to include input.h since it needs
that? At the moment I guess all hid.h users are just getting lucky or are
purposely including input.h themselves.

--Adam



-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to