On Sat, May 15, 2004 at 12:05:13AM +0200, Nemosoft Unv. wrote:
> -static int pwc_video_release(struct video_device *vfd)
> +static void pwc_video_release(struct video_device *vfd)
> {
> - Trace(TRACE_OPEN, "pwc_video_release() called. Now what?\n");
> + Trace(TRACE_OPEN, "pwc_video_release() called. Nothing to do here.
> Honestly.\n");
> }
This is STILL wrong. You will leak memory because of it.
I will not apply this patch because of this, sorry.
(for a hint of what you need to do here, try not setting the release
function and see what kind of message shows up in the syslog. It's
quite informative...)
And again, you did not CC me on this patch, so I almost missed it.
Please don't do that...
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
