On Tue, May 18, 2004 at 10:48:32PM +0200, Nemosoft Unv. wrote: > Hi, > > On Tuesday 18 May 2004 18:19, you wrote: > > On Sat, May 15, 2004 at 12:05:13AM +0200, Nemosoft Unv. wrote: > > > -static int pwc_video_release(struct video_device *vfd) > > > +static void pwc_video_release(struct video_device *vfd) > > > { > > > - Trace(TRACE_OPEN, "pwc_video_release() called. Now what?\n"); > > > + Trace(TRACE_OPEN, "pwc_video_release() called. Nothing to do here. > > > Honestly.\n"); } > > > > This is STILL wrong. You will leak memory because of it. > > I don't know how. Everything I need is malloc()ed and free()ed in > video_open() resp. video_close().
No, sysfs can hold open your device after video_close(). That's the whole point for the release callback. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel