> I've made all of the changes that recommended below. If it looks like
> I've missed anything, please indicate so.
>
>
[snip]
>>
>>>+ if (num_ports <= 0 || num_ports > 2) {
>>
>>
>> I like the idea of this check, but you are trying to test for a negative
>> value on a __u16 variable, which is always unsigned. So that check will
>> never be true :)
What happens if num_ports == 0? Not that hardware should ever report that.
[snip]
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g.
Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
