Alan Stern wrote:
On Mon, 24 May 2004, David Brownell wrote:


In fact, can't all the address select/assign code now be in hub.c?


Well, certainly it _can_... any non-static routine can live in any source file. In fact, maybe it _should_.

"Should" was more my thought. "Routines only needed in one module SHOULD live in that module and be declared 'static'."


The reason I didn't move it is because usb_release_address() is used in usb_new_device() and usb_disconnect(), both in usb.c.

Hmm, seems to me that it'd be cleaner to have the hub code handle all the address management. It's what calls those two routines, after all.

- Dave




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to