In fact, can't all the address select/assign code now be in hub.c?
The reason I didn't move it is because usb_release_address() is used in usb_new_device() and usb_disconnect(), both in usb.c.
Hmm, seems to me that it'd be cleaner to have the hub code handle all the address management. It's what calls those two routines, after all.
For that matter, why not move usb_new_device() and usb_disconnect() into hub.c as well? They only run in the hub driver, apart from virtual hubs.
Which are different parts of the hub driver, IMO. I've had much the same thought.
If you think that's a good idea, I'll create an extra patch in this series to take care of it along with the choose_configuration() power-budget error stuff.
If you like, and Greg takes both patches. The hub driver was neglected most of the way through the 2.5 series ... since then, that issue is getting redressed with vengeance! :)
- Dave
-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE.
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
