On Wed, 26 May 2004 12:12:15 -0400 (EDT) Alan Stern <[EMAIL PROTECTED]> wrote:
> Okay, I won't change any code without discussion. The comments could > stand to be clarified though; would anybody mind that? I am trying to get you to explain what you do not like about comments. They match the code perfectly (checked in 2.6.6). > I think it wouldn't hurt to change two aspects of this routine. The first > is simple: Nils Faerber has requested that the HUB_DEBOUNCE_TIMEOUT value > be increased from 400 ms to 1500 ms. That wouldn't affect normal stable > connections but it would give slightly flaky devices a better chance of > connecting properly. I am dubious. Do you have an actual report from him? > The second is to treat connect-change status properly -- make it reset the > stable_count value back to 0. The way it is now, if the connection status > is unstable and drops & returns within a 25 ms period, the routine won't > realize that anything has happened. *IF* I understand what you are talking about, you want to track USB_PORT_STAT_C_CONNECTION. I saw hubs with USB_PORT_STAT_C_CONNECTION now working right, this is why the "connection" variable is present at all. Otherwise, we would not need it. IIRC, 2.2 did not have it. In any case, this discussion is too vague. If you have an idea for a code change, please post a patch. -- Pete ------------------------------------------------------- This SF.Net email is sponsored by: Oracle 10g Get certified on the hottest thing ever to hit the market... Oracle 10g. Take an Oracle 10g class now, and we'll give you the exam FREE. http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
